RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v13]
Kevin Driver
kdriver at openjdk.org
Thu May 18 22:05:57 UTC 2023
On Thu, 18 May 2023 21:52:37 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>>
>> all review comments applied
>
> src/java.base/share/classes/sun/security/ssl/CertificateRequest.java line 385:
>
>> 383: X509ExtendedKeyManager km = chc.sslContext.getX509KeyManager();
>> 384: String clientAlias = null;
>> 385:
>
> Many of these lines are > 80 chars, which makes side-by-side challenging. Please keep line changes to a max of 80 chars.
>
> Didn't check the other file, but think I saw similar things there.
This might be something on your end @bradfordwetmore. I opened this in my IDE and went to the end of the line... It was right under the "String clientAlias" capital "S".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1198346964
More information about the security-dev
mailing list