RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v5]

Mark Powers mpowers at openjdk.org
Fri May 26 23:11:58 UTC 2023


On Tue, 23 May 2023 19:07:45 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   change class names and fix nit
>
> test/jdk/sun/security/provider/hss/TestHSSLMS.java line 26:
> 
>> 24: /*
>> 25:  * @test
>> 26:  * @bug JDK-8298127
> 
> Should just be `@bug 8298127`.

Fixed.

> test/jdk/sun/security/provider/hss/TestHSSLMS.java line 83:
> 
>> 81:                 verify(t.pk, t.sig, t.msg);
>> 82:                 return false;
>> 83:             } catch (InvalidKeySpecException | SignatureException ex) {
> 
> It would be nice to test for the expected exception, either `InvalidKeySpecException` or `SignatureException`. You could add an additional field to the `TestCase` record which checks for the expected exception type.

Fixed.

> test/micro/org/openjdk/bench/java/security/HSSLMS.java line 70:
> 
>> 68:     public void test01_RFC_8554() throws Exception {
>> 69:         // RFC 8554 Test Case 1
>> 70:         var pk = decode("""
> 
> If we are primarily interested in measuring the performance of the HSS/LMS verification, the decode parts should really be left out of that calculation and moved to `setup()` methods. Consider having separate inner/static subclasses for each test, and moving the decoding code to the `setup()` methods in each of those subclasses. See `test/micro/org/openjdk/bench/java/security/Signatures.java` for an example.

Fixed. It made a measurable difference.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13940#discussion_r1207464618
PR Review Comment: https://git.openjdk.org/jdk/pull/13940#discussion_r1207464673
PR Review Comment: https://git.openjdk.org/jdk/pull/13940#discussion_r1207464557


More information about the security-dev mailing list