RFR: JDK-8307794 Test for HSS/LMS Signature Verification [v5]

[Sean Mullan]

On Tue, 23 May 2023 17:14:42 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> https://bugs.openjdk.org/browse/JDK-8307794
>
> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change class names and fix nit

test/jdk/sun/security/provider/hss/TestHSSLMS.java line 26:

> 24: /*
> 25:  * @test
> 26:  * @bug JDK-8298127

Should just be `@bug 8298127`.

test/jdk/sun/security/provider/hss/TestHSSLMS.java line 83:

> 81:                 verify(t.pk, t.sig, t.msg);
> 82:                 return false;
> 83:             } catch (InvalidKeySpecException | SignatureException ex) {

It would be nice to test for the expected exception, either `InvalidKeySpecException` or `SignatureException`. You could add an additional field to the `TestCase` record which checks for the expected exception type.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13940#discussion_r1202871587
PR Review Comment: https://git.openjdk.org/jdk/pull/13940#discussion_r1202877384