RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

Valerie Peng valeriep at openjdk.org
Tue Oct 10 06:00:38 UTC 2023


On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> A few classes in `com.sun.crypto.provider` package have non-final fields which could easily be marked `final`.

src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 109:

> 107:     int tagLenBytes = DEFAULT_TAG_LEN;
> 108:     // Key size if the value is passed, in bytes.
> 109:     private final int keySize;

Why not also mark the `blockCipher` as private final?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15412#discussion_r1351536561



More information about the security-dev mailing list