RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

Valerie Peng valeriep at openjdk.org
Tue Oct 10 19:39:19 UTC 2023


On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> A few classes in `com.sun.crypto.provider` package have non-final fields which could easily be marked `final`.

src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java line 102:

> 100:      * Hash entries are keyed by alias names.
> 101:      */
> 102:     private final Hashtable<String, Object> entries = new Hashtable<String, Object>();

If the line is longer than 80 chars, the convention is to break it into 2 lines.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15412#discussion_r1353227207



More information about the security-dev mailing list