RFR: 8318486: Rename JavaLangAccess.xxNoRepl to xxReportError [v2]

Chen Liang liach at openjdk.org
Fri Oct 20 02:32:35 UTC 2023


On Fri, 20 Oct 2023 02:29:15 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Please review a patch that renames `JavaLangAccess::xxNoRepl` to `xxReportError` to explicitly indicate these APIs report encoding errors.
>> 
>> The old "NoRepl" suffix presumably means "No Replacement", but it has been misunderstood as "No Replication" (#16209) and misused as an array sharing API in performance optimization patches.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   NoRepl -> ReportError

I have decided to rename `NoRepl` to `ReportError`, as it corresponds to `CodingErrorAction.REPORT`. I have replaced all `NoRepl` occurrences I've found with `ReportError`, including in tests.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16260#issuecomment-1771979541



More information about the security-dev mailing list