RFR: 8315968: Consolidate java.util.Digits and StringLatin1::PACKED_DIGITS [v10]

温绍锦 duke at openjdk.org
Mon Sep 11 23:34:41 UTC 2023


On Mon, 11 Sep 2023 19:03:45 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 1:
>> 
>>> 1: /*
>> 
>> Can git be convinced to show this as a rename instead of a delete and add?
>> The history will be cleaner.
>
> I just looked it up and git actually doesn't have commands for renames like hg, but rather decides if something is a delete+add or a rename based on the amount of changes. Too many changes and it'll automatically look like a remove+add. 
> 
> Which is yet another argument for splitting up this in multiple PRs. One to move, one to refactor.

Refactoring of stringSize has been restored, But the problem of 'delete & add' is still not solved, I tried rebase but it couldn't be solved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15651#discussion_r1322178111


More information about the security-dev mailing list