RFR: JDK-8296631 NSS tests failing on OL9 linux-aarch64 hosts

Mark Powers mpowers at openjdk.org
Mon Sep 18 15:51:40 UTC 2023


On Thu, 14 Sep 2023 23:18:39 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> https://bugs.openjdk.org/browse/JDK-8296631
>
> test/jdk/sun/security/pkcs11/Secmod/AddPrivateKey.java line 74:
> 
>> 72:         if (version == 0.0 || version >= 3.55) {
>> 73:             useSqlite(true);
>> 74:         }
> 
> Instead of updating various tests with this block, how about doing this inside SecmodTest.initSecmod()?

Such a change would apply NSS version number checks to `TestNssDbSqlite` which currently doesn't have them.  But wait! If `TestNssDbSqlite` has been running for years on all NSS versions, then it should be safe to make sqlite the default for all tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15644#discussion_r1328938101


More information about the security-dev mailing list