RFR: JDK-8296631 NSS tests failing on OL9 linux-aarch64 hosts

[Valerie Peng]

On Mon, 18 Sep 2023 15:49:10 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> test/jdk/sun/security/pkcs11/Secmod/AddPrivateKey.java line 74:
>> 
>>> 72:         if (version == 0.0 || version >= 3.55) {
>>> 73:             useSqlite(true);
>>> 74:         }
>> 
>> Instead of updating various tests with this block, how about doing this inside SecmodTest.initSecmod()?
>
> Such a change would apply NSS version number checks to `TestNssDbSqlite` which currently doesn't have them.  But wait! If `TestNssDbSqlite` has been running for years on all NSS versions, then it should be safe to make sqlite the default for all tests.

Yes, for new NSS releases, it should be safe to set sqlite to true by default. The tests which relies on sqlite like `TestNssDbSqlite` can always call useSqlite(true) regardless of default.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15644#discussion_r1330812595