RFR: JDK-8315042 NPE in PKCS7.parseOldSignedData [v2]

Valerie Peng valeriep at openjdk.org
Thu Sep 21 19:18:56 UTC 2023


On Thu, 21 Sep 2023 17:25:34 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> test/jdk/sun/security/x509/X509CRLImpl/UnexpectedNPE.java line 1:
>> 
>>> 1: /*
>> 
>> I would suggest write a new test, and you can use the `Utils.runAndCheckException` to make it simpler.
>
> I can do that. My primary motivation for using the existing test was that `UnexpectedNPE.java` is the perfect name for my test.

Why not just updating UnexpectedNPE test with `Utils.runAndCheckException` calls?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15844#discussion_r1333501852


More information about the security-dev mailing list