RFR: 8336665: CCE in X509CRLImpl$TBSCertList.getCertIssuer [v2]

Sean Mullan mullan at openjdk.org
Mon Aug 12 19:22:34 UTC 2024


On Mon, 12 Aug 2024 15:44:11 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> https://bugs.openjdk.org/browse/JDK-8336665
>
> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   copyright and unnecessary initialization

src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 291:

> 289:                 X500Name issuerDN;
> 290:                 try {
> 291:                     issuerDN = (X500Name) names.get(0).getName();

Use `instanceof X500Name` here to see if it is the right type instead of catching the `ClassCastException`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20528#discussion_r1714263963



More information about the security-dev mailing list