RFR: 8336665: CCE in X509CRLImpl$TBSCertList.getCertIssuer [v2]

Mark Powers mpowers at openjdk.org
Thu Aug 15 14:49:49 UTC 2024


On Mon, 12 Aug 2024 19:20:17 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   copyright and unnecessary initialization
>
> src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 291:
> 
>> 289:                 X500Name issuerDN;
>> 290:                 try {
>> 291:                     issuerDN = (X500Name) names.get(0).getName();
> 
> Use `instanceof X500Name` here to see if it is the right type instead of catching the `ClassCastException`.

Fixed. Good Idea.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20528#discussion_r1718510068



More information about the security-dev mailing list