RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

Valerie Peng valeriep at openjdk.org
Wed Aug 14 16:50:55 UTC 2024


On Wed, 14 Aug 2024 15:30:48 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Since it must be overridden, no way for the `UnsupportedOperationException` to happen?
>
> The text implies that implementations may throw `UnsupportedOperationException` in their method body, even though they are technically forced to override the method.

Well, I'd strongly suggest changing the text to something like "if the parameters cannot be retrieved" or "if the provider does not support parameter retrieval". I've seen the existing text used in other classes, however, those methods are not abstract and do throw `UnsupportedOperationException`. Now that the method is made abstract to force the override, the text should be adjusted as well...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1717258287



More information about the security-dev mailing list