RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

Kevin Driver kdriver at openjdk.org
Fri Aug 16 21:16:36 UTC 2024


On Wed, 14 Aug 2024 16:47:38 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> The text implies that implementations may throw `UnsupportedOperationException` in their method body, even though they are technically forced to override the method.
>
> Well, I'd strongly suggest changing the text to something like "if the parameters cannot be retrieved" or "if the provider does not support parameter retrieval". I've seen the existing text used in other classes, however, those methods are not abstract and do throw `UnsupportedOperationException`. Now that the method is made abstract to force the override, the text should be adjusted as well...

Addressed in https://github.com/openjdk/jdk/pull/20301/commits/c6f491cd05c76088e6431b2ba9d4ab42b29e4055. Please indicate if this is resolved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1720349634



More information about the security-dev mailing list