RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

[Kevin Driver]

On Thu, 15 Aug 2024 20:30:38 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java line 293:
>> 
>>> 291:      *     {@code HkdfParameterSpec}
>>> 292:      */
>>> 293:     protected byte[] hkdfExtract(SecretKey inputKey, byte[] salt)
>> 
>> Use the name `inputKeyMaterial` instead of `inputKey` for consistency? Seems easier to use `byte[]` for its type since all you need is just the bytes.
>
> This method can be made "private" since there is no need for sub-class to override it?

> Use the name `inputKeyMaterial` instead of `inputKey` for consistency? Seems easier to use `byte[]` for its type since all you need is just the bytes.

We can consider a rename of this parameter. See related comments for why we would use SecretKey instead of byte[].

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1718994700