RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

Valerie Peng valeriep at openjdk.org
Fri Aug 16 18:07:58 UTC 2024


On Thu, 15 Aug 2024 21:06:13 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> This method can be made "private" since there is no need for sub-class to override it?
>
>> Use the name `inputKeyMaterial` instead of `inputKey` for consistency? Seems easier to use `byte[]` for its type since all you need is just the bytes.
> 
> We can consider a rename of this parameter. See related comments for why we would use SecretKey instead of byte[].

Well, I don't share your comments/reason on why SecretKey is needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1720153918



More information about the security-dev mailing list