RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

[Valerie Peng]

On Fri, 16 Aug 2024 21:10:54 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 428:
>> 
>>> 426:          * <p>
>>> 427:          * Note: {@code addIKMValue} and {@code addSaltValue} may be called
>>> 428:          * afterward to supply additional values, if desired
>> 
>> What does this mean? {@code addIKMValue} and {@code addSaltValue} are methods of (@code Builder} class and do not belong to the {@code ExtractThenExpand} class. Copy-n-paste error?
>
> Addressed in https://github.com/openjdk/jdk/pull/20301/commits/c6f491cd05c76088e6431b2ba9d4ab42b29e4055. Please indicate if this is resolved.

Yes, resolved.

>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 443:
>> 
>>> 441:          *     if {@code length} is not > 0
>>> 442:          */
>>> 443:         private ExtractThenExpand(Extract ext, byte[] info, int length) {
>> 
>> Check {@code ext} to be not null?
>
> Addressed in https://github.com/openjdk/jdk/pull/20301/commits/c6f491cd05c76088e6431b2ba9d4ab42b29e4055. Please indicate if this is resolved.

Yes, resolved.

>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 444:
>> 
>>> 442:          */
>>> 443:         private ExtractThenExpand(Extract ext, byte[] info, int length) {
>>> 444:             // null-checked previously
>> 
>> nit: where is this checked? I didn't find it. The comment seems incorrect.
>
> Addressed in https://github.com/openjdk/jdk/pull/20301/commits/c6f491cd05c76088e6431b2ba9d4ab42b29e4055. Please indicate if this is resolved.

Yes, resolved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1724075490
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1724076275
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1724076537