RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

Valerie Peng valeriep at openjdk.org
Tue Aug 20 23:18:11 UTC 2024


On Fri, 16 Aug 2024 21:11:43 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java line 86:
>> 
>>> 84:      *
>>> 85:      * @throws InvalidAlgorithmParameterException
>>> 86:      *     if the information contained within the {@code KDFParameterSpec} is
>> 
>> typo: `KDFParaneterSpec` should be `derivationParameterSpec`.
>> BTW, I assume the javadoc is copied from `KDFSpi` class. I'd suggest to shorten it and match it to the actual implementation instead of the general description as in `KDFSpi`.
>> For the last sentence, do you have an example of how the `derivationParameterSpec` typed `HKDFParameterSpec` can specify a type of output that is not a key?
>
> Addressed in https://github.com/openjdk/jdk/pull/20301/commits/c6f491cd05c76088e6431b2ba9d4ab42b29e4055. Please indicate if this is resolved.

Yes, resolved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1724084059



More information about the security-dev mailing list