RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256

Ferenc Rakoczi duke at openjdk.org
Mon Aug 26 14:33:03 UTC 2024


On Sat, 24 Aug 2024 20:10:51 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> In preparation for the new PQC algorithms implementations, internal XOF (eXtendable Output Function) methods are added to the SHAKE128 and SHAKE256 implementations.
>
> src/java.base/share/classes/sun/security/provider/SHA3.java line 211:
> 
>> 209:             squeezeOffset += bytesToCopy;
>> 210:         }
>> 211: 
> 
> Is it possible to add a return here if `numBytes` is already zero?

Yes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20631#discussion_r1731338937



More information about the security-dev mailing list