RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256 [v2]
YouliangGuo
duke at openjdk.org
Mon Aug 26 15:29:03 UTC 2024
On Sat, 24 Aug 2024 19:11:09 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Accepting review comments.
>
> src/java.base/share/classes/sun/security/provider/SHA3.java line 72:
>
>> 70: private final byte suffix;
>> 71: private long[] state = new long[DM*DM];
>> 72: private int squeezeOffset = -1;
>
> Add some comment for `squeezeOffset`.
agree with Weijun, it is better to put a comment to explain why -1 is initialized
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20631#discussion_r1731262772
More information about the security-dev
mailing list