RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256 [v2]

Weijun Wang weijun at openjdk.org
Mon Aug 26 15:36:06 UTC 2024


On Mon, 26 Aug 2024 14:53:36 GMT, Ferenc Rakoczi <duke at openjdk.org> wrote:

>> In preparation for the new PQC algorithms implementations, internal XOF (eXtendable Output Function) methods are added to the SHAKE128 and SHAKE256 implementations.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Accepting review comments.

src/java.base/share/classes/sun/security/provider/SHA3.java line 78:

> 76: 
> 77:     // The byte offset in the state where the next sqeeze() will start.
> 78:     // -1 indicates that either we are in the absorbing phase (only

I see `either` but no `or`. Did you meant to talk about `reset`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20631#discussion_r1731430102



More information about the security-dev mailing list