RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256 [v2]
Ferenc Rakoczi
duke at openjdk.org
Tue Aug 27 13:05:42 UTC 2024
On Mon, 26 Aug 2024 15:33:42 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Accepting review comments.
>
> src/java.base/share/classes/sun/security/provider/SHA3.java line 78:
>
>> 76:
>> 77: // The byte offset in the state where the next sqeeze() will start.
>> 78: // -1 indicates that either we are in the absorbing phase (only
>
> I see `either` but no `or`. Did you meant to talk about `reset`?
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20631#discussion_r1732811099
More information about the security-dev
mailing list