RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

[Sean Mullan]

On Mon, 19 Aug 2024 21:37:29 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> How about the "may" => "should" change?
>
> Addressed in https://github.com/openjdk/jdk/pull/20301/commits/48395b86ba8e1cda663ae326e06ae2556f4b905a. Please indicate if this is resolved.

I think "cannot be null" or "must not be null" is more precise and unambiguous. The "should" and "may" words should be avoided. This comment applies to all exception messages with "may not" in the message.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1731487176