RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

Kevin Driver kdriver at openjdk.org
Wed Aug 28 20:44:12 UTC 2024


On Mon, 26 Aug 2024 16:20:31 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Addressed in https://github.com/openjdk/jdk/pull/20301/commits/48395b86ba8e1cda663ae326e06ae2556f4b905a. Please indicate if this is resolved.
>
> I think "cannot be null" or "must not be null" is more precise and unambiguous. The "should" and "may" words should be avoided. This comment applies to all exception messages with "may not" in the message.

Resolved in https://github.com/openjdk/jdk/pull/20301/commits/a65dc9da044297c313e02d698255bad915dc0a10

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1735259391


More information about the security-dev mailing list