RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v14]

[Kevin Driver]

On Wed, 21 Aug 2024 17:50:23 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   addresses delayed provider selection where parameters are involved
>
> test/jdk/javax/crypto/KDF/Threading.java line 68:
> 
>> 66:         assert (HexFormat.of().formatHex(result.getEncoded()).equals(
>> 67:             expectedResult));
>> 68:     }
> 
> Maybe also check the deriveData() and validate the output value and rename the test to testDerive()?
> For completeness sake, we should also cover deriveData(...) call.

Resolved in https://github.com/openjdk/jdk/pull/20301/commits/a65dc9da044297c313e02d698255bad915dc0a10.

> test/jdk/security/unsignedjce/java.base/javax/crypto/ProviderVerifier.java line 1:
> 
>> 1: /*
> 
> This is exact the same code as the one in OpenJDK.
> For the Delayed.java, it just needs the bare minimum, e.g. do not error out when verify() is called. For testing purpose, maybe we can just use a stub version instead of duplicating the OpenJDK one? If later, the OpenJDK one changed, people may wonder what this is for and have to read through the whole impl, If it's just the stub version, it's very clear.

Resolved in https://github.com/openjdk/jdk/pull/20301/commits/a65dc9da044297c313e02d698255bad915dc0a10.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1735260622
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1735260845