RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v14]

Valerie Peng valeriep at openjdk.org
Wed Aug 28 23:47:32 UTC 2024


On Wed, 28 Aug 2024 20:36:06 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> test/jdk/security/unsignedjce/java.base/javax/crypto/ProviderVerifier.java line 1:
>> 
>>> 1: /*
>> 
>> This is exact the same code as the one in OpenJDK.
>> For the Delayed.java, it just needs the bare minimum, e.g. do not error out when verify() is called. For testing purpose, maybe we can just use a stub version instead of duplicating the OpenJDK one? If later, the OpenJDK one changed, people may wonder what this is for and have to read through the whole impl, If it's just the stub version, it's very clear.
>
> Resolved in https://github.com/openjdk/jdk/pull/20301/commits/a65dc9da044297c313e02d698255bad915dc0a10.

Good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1735397788


More information about the security-dev mailing list