RFR: 8343775: Add since checker tests to the security area modules [v2]

Nizar Benalla nbenalla at openjdk.org
Sun Dec 1 23:02:51 UTC 2024


On Thu, 14 Nov 2024 01:35:10 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this PR that add tests to verify the value of `@since` tags to the Serviceability area modules. The test is described in this [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442.
>> 
>> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation). And lessen the burden on Reviewers.
>> 
>> The test has been added for `java.base` and a few other modules and has helped catch some bugs before they make it to the JDK.
>> 
>> Note: The test for `jdk.crypto.mscapi` is missing as I noticed a failure when running it on that module, I will add it in a future PR after patching the cause of the failure (Whether it's a missing `@since` or something else)
>> 
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - fix a couple mistakes in jtreg comment
>  - Revert "remove backticks"
>    
>    This reverts commit 496ca99146feb08935a196641736092fb5cdef15.

Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21986#issuecomment-2510290990


More information about the security-dev mailing list