RFR: 8333477: Delete extra empty spaces in Makefiles [v2]

Julian Waters jwaters at openjdk.org
Fri Jun 7 12:40:13 UTC 2024


On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>>   This PR several extra empty spaces and extra empty lines in several Makefiles. It's trivial fix, no risk.
>> 
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   delete extra empty trailing blank line in test/jdk/java/rmi/reliability/benchmark/bench/Makefile

Marked as reviewed by jwaters (Committer).

test/jdk/java/rmi/reliability/benchmark/bench/Makefile line 50:

> 48: clean:
> 49: 	rm -f *.class .classes
> 50: 

Hmm, shouldn't this newline at EOF be kept? Asking @ all the people who've reviewed this so far, no need to change it just yet

-------------

PR Review: https://git.openjdk.org/jdk/pull/19537#pullrequestreview-2104439647
PR Review Comment: https://git.openjdk.org/jdk/pull/19537#discussion_r1631140418



More information about the security-dev mailing list