RFR: 8333477: Delete extra empty spaces in Makefiles [v2]

Erik Joelsson erikj at openjdk.org
Fri Jun 7 12:51:17 UTC 2024


On Fri, 7 Jun 2024 12:37:48 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   delete extra empty trailing blank line in test/jdk/java/rmi/reliability/benchmark/bench/Makefile
>
> test/jdk/java/rmi/reliability/benchmark/bench/Makefile line 50:
> 
>> 48: clean:
>> 49: 	rm -f *.class .classes
>> 50: 
> 
> Hmm, shouldn't this newline at EOF be kept? Asking @ all the people who've reviewed this so far, no need to change it just yet

No, it's an extra newline. A file should end with a newline but one is enough.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19537#discussion_r1631152127



More information about the security-dev mailing list