RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider

Valerie Peng valeriep at openjdk.org
Tue Jun 11 01:08:17 UTC 2024


On Tue, 4 Jun 2024 02:32:31 GMT, Mark Powers <mpowers at openjdk.org> wrote:

> https://bugs.openjdk.org/browse/JDK-8333364

src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Cipher.java line 764:

> 762:     @Override
> 763:     protected int engineDoFinal(byte[] in, int inOfs, int inLen, byte[] out,
> 764:             int outOfs) throws ShortBufferException, AEADBadTagException {

Not relevant to this line, but down below in the javadoc of `engineDoFinal(ByteBuffer, ByteBuffer)`, the method throws `ShortBufferException`, but the javadoc doesn't have it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1634023709



More information about the security-dev mailing list