RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider

Valerie Peng valeriep at openjdk.org
Mon Jun 10 23:39:12 UTC 2024


On Tue, 4 Jun 2024 02:32:31 GMT, Mark Powers <mpowers at openjdk.org> wrote:

> https://bugs.openjdk.org/browse/JDK-8333364

src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Cipher.java line 678:

> 676:     protected int engineUpdate(byte[] in, int inOfs, int inLen,
> 677:             byte[] out, int outOfs) throws ShortBufferException {
> 678:         int bytesUpdated;

Not relevant to this line, but rather down below in the javadoc of engineUpdate(ByteBuffer, ByteBuffer), the javadoc has {@code out} but the variable name is `output`, probably a copy-n-paste error from this method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1633978042



More information about the security-dev mailing list