RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider [v3]

Mark Powers mpowers at openjdk.org
Thu Jun 13 21:35:13 UTC 2024


On Thu, 13 Jun 2024 21:23:27 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> No. The two variables wouldn't be in scope for the `finally` block on line 276.
>
> How about right above the block where they are assigned? The reason that I suggested this is that it's easier to see why no default value needed when they are placed nearer to where they are used.

Right above the `try` block? That would work.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1638973897



More information about the security-dev mailing list