RFR: 8334670: SSLSocketOutputRecord buffer miscalculation

Daniel Jeliński djelinski at openjdk.org
Tue Jun 25 07:44:09 UTC 2024


On Mon, 24 Jun 2024 15:57:57 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

> Hi,
> 
> I need a review to change the a fragment buffer size miscalculation error.   This appears when there are large handshake messages and hasn't been observed during application data.  This was found during testing of the NewSessionTicket change in [JDK-8328608](https://bugs.openjdk.org/browse/JDK-8328608).  There is no regression test as the failure hasn't shown to fail every time. 
> 
> thanks
> 
> Tony

LGTM. Thanks for fixing this!

In order to test this fix, we would need to trigger a situation where `count != position`, and it seems to be impossible, because we flush after every single message. We don't need to flush that often; I'll log a ticket for this.

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19862#pullrequestreview-2137720958



More information about the security-dev mailing list