RFR: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message [v5]

Prasadrao Koppula pkoppula at openjdk.org
Thu Mar 21 02:07:21 UTC 2024


On Wed, 20 Mar 2024 15:56:22 GMT, John Jiang <jjiang at openjdk.org> wrote:

>> Prasadrao Koppula has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8326643
>
> test/jdk/javax/net/ssl/TLSv13/EngineOutOfSeqCCS.java line 280:
> 
>> 278:             log("===== " + header + " (" + tlsRecType(type) + " / " +
>> 279:                 ver_major + "." + ver_minor + " / " +
>> 280:                 bufLen + " bytes) =====");
> 
> Do you want to print `recLen` or `bufLen`? `recLen` is not used yet.

Its bufLen

> test/jdk/javax/net/ssl/TLSv13/EngineOutOfSeqCCS.java line 284:
> 
>> 282:             for (int i = 0; i < bufLen; i++) {
>> 283:                 if (i != 0 && i % 16 == 0) {
>> 284:                     System.out.print("\n");
> 
> Just `System.out.println()`?

For readability, Intentionally added "\n"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18372#discussion_r1533147793
PR Review Comment: https://git.openjdk.org/jdk/pull/18372#discussion_r1533148397



More information about the security-dev mailing list