RFR: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message [v5]

Prasadrao Koppula pkoppula at openjdk.org
Thu Mar 21 02:26:21 UTC 2024


On Wed, 20 Mar 2024 16:32:30 GMT, John Jiang <jjiang at openjdk.org> wrote:

>> Prasadrao Koppula has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8326643
>
> test/jdk/javax/net/ssl/TLSv13/EngineOutOfSeqCCS.java line 253:
> 
>> 251:     }
>> 252: 
>> 253:     private static void log(String str) {
> 
> I suggest method `log` accepts `String...` instead of `String`.
> This method can concatenate the strings, then its callers don't need to use so many `+` to concatenate the log.

We have multiple options to pass String ('+')/ String[]/ String../.join()/StringBuilder/.. I thought using '+'is not a bad idea

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18372#discussion_r1533168431



More information about the security-dev mailing list