RFR: 8319332: Security properties files inclusion [v11]
Weijun Wang
weijun at openjdk.org
Thu May 2 19:11:58 UTC 2024
On Thu, 2 May 2024 19:06:00 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Profiles documentation adjustments.
>>
>> Co-authored-by: Francisco Ferrari <fferrari at redhat.com>
>> Co-authored-by: Martin Balao <mbalao at redhat.com>
>
> src/java.base/share/conf/security/java.security line 69:
>
>> 67: # statement will override any matching property defined in a profile. In order
>> 68: # to avoid this behavior, the include statement may be placed at the end of
>> 69: # this file.
>
> It's probably better to place the newly added "Security properties defined after an include statement..." in an individual paragraph since it's not limited to "the latter case" (or you mean "last"?). Then you might not want to use the "profile" word since it's not defined elsewhere.
Instead of "to avoid this behavior", how about "if you want the properties defined in the included file to override those in the main file"?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16483#discussion_r1588204601
More information about the security-dev
mailing list