RFR: 8331008: KDF Implementation (Preview) [v2]

[Kevin Driver]

On Thu, 9 May 2024 16:42:09 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - move the test to the correct directory, which was already created
>>  - tests passing
>>  - start deriveKey
>>  - remove SHA224 mentions
>>  - remove SHA224 mentions
>>  - additional helper methods
>>  - parameter validation for impl
>>  - parameter validation for impl
>>  - initial commit into open
>
> src/java.base/share/classes/javax/crypto/KDFSpi.java line 45:
> 
>> 43:      * provides access to the KDF alg params for implementers of the Spi
>> 44:      */
>> 45:     protected final AlgorithmParameterSpec algorithmParameterSpec;
> 
> Putting the parameter object here means every time a subclass wants to use it it needs to cast it to a child type. If it's not used inside this class, I suggest each sub class maintaining its own.

Contemplating ...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1597235325