RFR: 8331008: KDF Implementation (Preview) [v2]

[Sean Mullan]

On Fri, 10 May 2024 21:13:22 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/KDFSpi.java line 45:
>> 
>>> 43:      * provides access to the KDF alg params for implementers of the Spi
>>> 44:      */
>>> 45:     protected final AlgorithmParameterSpec algorithmParameterSpec;
>> 
>> Putting the parameter object here means every time a subclass wants to use it it needs to cast it to a child type. If it's not used inside this class, I suggest each sub class maintaining its own.
>
> Contemplating ...

Yes, I don't think should be exposed as a protected field since it is passed to the constructor and subclasses can store it as a private variable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598820136