RFR: 8331008: KDF Implementation (Preview) [v28]

Alan Bateman alanb at openjdk.org
Mon May 13 09:06:10 UTC 2024


On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic algorithms for deriving additional keys from a secret key and other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
> 
>   re-enable preview annotations

src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 121:

> 119:          *     the initial key material value (null values will not be added)
> 120:          *
> 121:          * @return a new {@code Extract} object

Looks like a copy+paste error with the return description in the addXXX methods. They should say that they return "this builder".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598124427



More information about the security-dev mailing list