RFR: 8331008: KDF Implementation (Preview) [v28]

Kevin Driver kdriver at openjdk.org
Mon May 13 16:30:55 UTC 2024


On Mon, 13 May 2024 09:02:42 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   re-enable preview annotations
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 121:
> 
>> 119:          *     the initial key material value (null values will not be added)
>> 120:          *
>> 121:          * @return a new {@code Extract} object
> 
> Looks like a copy+paste error with the return description in the addXXX methods. They should say that they return "this builder".

see: 3bac21f8151

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598744344



More information about the security-dev mailing list