RFR: 8331008: KDF Implementation (Preview) [v26]

Weijun Wang weijun at openjdk.org
Mon May 13 14:20:23 UTC 2024


On Sun, 12 May 2024 14:43:04 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   commenting out until better understood -- causing failures
>
> src/java.base/share/classes/javax/crypto/KDF.java line 395:
> 
>> 393:      * <p>
>> 394:      * The {@code deriveKey} method may be called multiple times once a
>> 395:      * {@code KDF} object is initialized.
> 
> I think this sentence is important enough that it should be repeated in the class summary.
> 
> s/initialized/instantiated/

Do we need to mention "at the same time" because it's thread-safe?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598524313



More information about the security-dev mailing list