RFR: 8331008: KDF Implementation (Preview) [v26]

Sean Mullan mullan at openjdk.org
Mon May 13 15:08:17 UTC 2024


On Mon, 13 May 2024 13:57:10 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/KDF.java line 395:
>> 
>>> 393:      * <p>
>>> 394:      * The {@code deriveKey} method may be called multiple times once a
>>> 395:      * {@code KDF} object is initialized.
>> 
>> I think this sentence is important enough that it should be repeated in the class summary.
>> 
>> s/initialized/instantiated/
>
> Do we need to mention "at the same time" because it's thread-safe?

Yes, how about: "The `deriveKey` and `deriveData` methods of `KDF` objects must be thread-safe. That is, multiple threads may concurrently invoke these methods on a single KDF object with no ill effects."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598633471



More information about the security-dev mailing list