RFR: 8325766: Review seclibs tests for cert expiry [v2]
Matthew Donovan
mdonovan at openjdk.org
Wed May 22 14:45:26 UTC 2024
> For this PR, I identified TLS tests that can fail due to hard-code certificates expiring. I updated those tests to use certificates that are generated programmatically. This includes adding some helper methods to the CertificateBuilder class to create builder objects with common default values. The builder can be further customized to meet the needs of the test. I also refactored some of the tests to put common functionality in base classes, further reducing duplicated code.
>
> This PR does not include changes to SSLContextTemplate and the tests that use it. These tests require significant refactoring to incorporate programmatically generated certificates and should be a separate task.
Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- renamed CertificateBuilder methods, updated tests, and removed duplication
- Merge branch 'master' into certbuilding
- 8325766: Review seclibs tests for cert expiry
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18958/files
- new: https://git.openjdk.org/jdk/pull/18958/files/f211b615..d52e1265
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18958&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18958&range=00-01
Stats: 17018 lines in 1511 files changed: 4803 ins; 7547 del; 4668 mod
Patch: https://git.openjdk.org/jdk/pull/18958.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18958/head:pull/18958
PR: https://git.openjdk.org/jdk/pull/18958
More information about the security-dev
mailing list