RFR: 8298390: Implementing ML-KEM key encapsulation mechanism [v9]

Sean Mullan mullan at openjdk.org
Tue Nov 5 20:20:33 UTC 2024


On Tue, 5 Nov 2024 04:04:45 GMT, Ben Perez <bperez at openjdk.org> wrote:

>> Java implementation of ML-KEM, the [FIPS 203](https://csrc.nist.gov/pubs/fips/203/final) post-quantum KEM scheme. Depends on https://github.com/openjdk/jdk/pull/21167
>
> Ben Perez has updated the pull request incrementally with one additional commit since the last revision:
> 
>   trailing whitespace

Changes requested by mullan (Reviewer).

src/java.base/share/classes/com/sun/crypto/provider/ML_KEM.java line 1:

> 1: package com.sun.crypto.provider;

Missing copyright.

src/java.base/share/classes/com/sun/crypto/provider/SHA3Parallel.java line 1:

> 1: package sun.security.provider;

Missing copyright.

test/micro/org/openjdk/bench/java/security/MLKEMBench.java line 1:

> 1: package org.openjdk.bench.java.security;

Missing copyright.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21478#pullrequestreview-2416603096
PR Review Comment: https://git.openjdk.org/jdk/pull/21478#discussion_r1829950213
PR Review Comment: https://git.openjdk.org/jdk/pull/21478#discussion_r1829947774
PR Review Comment: https://git.openjdk.org/jdk/pull/21478#discussion_r1829950624


More information about the security-dev mailing list