RFR: 8298390: Implementing ML-KEM key encapsulation mechanism [v9]

Weijun Wang weijun at openjdk.org
Thu Nov 7 00:47:35 UTC 2024


On Tue, 5 Nov 2024 20:17:47 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Ben Perez has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   trailing whitespace
>
> src/java.base/share/classes/com/sun/crypto/provider/ML_KEM.java line 1:
> 
>> 1: package com.sun.crypto.provider;
> 
> Missing copyright.

Fixed.

> src/java.base/share/classes/com/sun/crypto/provider/SHA3Parallel.java line 1:
> 
>> 1: package sun.security.provider;
> 
> Missing copyright.

Fixed.

> src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java line 1:
> 
>> 1: /*
> 
> Add the ML-KEM algorithms as a comment to the Supported algorithms and their names (see lines 47-79).
> 
> Also, add ML-KEM to the static info String (see lines 88-90).

Fixed.

> test/micro/org/openjdk/bench/java/security/MLKEMBench.java line 1:
> 
>> 1: package org.openjdk.bench.java.security;
> 
> Missing copyright.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21478#discussion_r1831899155
PR Review Comment: https://git.openjdk.org/jdk/pull/21478#discussion_r1831899117
PR Review Comment: https://git.openjdk.org/jdk/pull/21478#discussion_r1831900154
PR Review Comment: https://git.openjdk.org/jdk/pull/21478#discussion_r1831899187


More information about the security-dev mailing list