RFR: 8341964: Add mechanism to disable different parts of TLS cipher suite [v9]

Lothar Kimmeringer duke at openjdk.org
Sat Nov 9 13:48:57 UTC 2024


On Sat, 9 Nov 2024 00:07:07 GMT, Artur Barashev <abarashev at openjdk.org> wrote:

>> The current syntax of the jdk.tls.disabledAlgorithms makes it difficult to disable algorithms that affect both the key exchange and authentication parts of a TLS cipher suite. For example, if you add "RSA" to the jdk.tls.disabledAlgorithms security property, it disables all cipher suites that use RSA, whether it is for key exchange or authentication. If you only want to disable cipher suites that use RSA for key exchange, the only workaround is to list the whole cipher suite name, so an exact match is done, but if there are many cipher suites that use that key exchange algorithm, this becomes cumbersome.
>
> Artur Barashev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Set initial cache size

test/jdk/sun/security/ssl/CipherSuite/AbstractDisableCipherSuites.java line 48:

> 46:     private static final byte HSMSG_CLIHELLO = 0x01;
> 47:     private static final ByteBuffer CLIOUTBUF =
> 48:             ByteBuffer.wrap("Client Side".getBytes());

That's something more on a nitpick-level but `getBytes()` uses the system's encoding. On IBM i this is EBCDIC and there might be systems out there using Little/BigEndian-Encodings. I assume this will break this test, won't it? `getBytes("8859_1")` should prevent that, called in a static-Block in order to catch the declared exception.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21841#discussion_r1835376988


More information about the security-dev mailing list