RFR: 8341964: Add mechanism to disable different parts of TLS cipher suite [v9]

Artur Barashev abarashev at openjdk.org
Tue Nov 12 15:01:23 UTC 2024


On Sat, 9 Nov 2024 13:46:06 GMT, Lothar Kimmeringer <duke at openjdk.org> wrote:

>> Artur Barashev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Set initial cache size
>
> test/jdk/sun/security/ssl/CipherSuite/AbstractDisableCipherSuites.java line 48:
> 
>> 46:     private static final byte HSMSG_CLIHELLO = 0x01;
>> 47:     private static final ByteBuffer CLIOUTBUF =
>> 48:             ByteBuffer.wrap("Client Side".getBytes());
> 
> That's something more on a nitpick-level but `getBytes()` uses the system's encoding. On IBM i this might be EBCDIC and there might be systems out there using UTF16/LittleEndian/BigEndian-Encodings. I assume this will break this test, won't it? `getBytes("8859_1")` should prevent that, called in a static-Block in order to catch the declared exception.

It won't break the test, these are just some raw bytes we wrap with SSLEngine during the tests, they can be whatever.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21841#discussion_r1838254238


More information about the security-dev mailing list