RFR: 8344120: Remove Security Manager dependencies from jdk.crypto.cryptoki module

[Anthony Scarpino]

On Wed, 13 Nov 2024 14:44:06 GMT, Sean Mullan <mullan at openjdk.org> wrote:

> Now that JEP 486 has been integrated, the `jdk.crypto.cryptoki` implementation dependencies on `System.getSecurityManager` and `AccessController.doPrivileged` can be removed.

One minor question, but it looks good as is.

src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyAgreement.java line 77:

> 75: 
> 76:         private static boolean getValue() {
> 77:             return Boolean.getBoolean("jdk.crypto.KeyAgreement.legacyKDF");

I'm fine with the code as is, but is there a reason why `Boolean.getBoolean(...)` is not replacing the method call on line 74?  Is there initialization/startup concerns?

-------------

Marked as reviewed by ascarpino (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22077#pullrequestreview-2433970821
PR Review Comment: https://git.openjdk.org/jdk/pull/22077#discussion_r1840884862