RFR: 8344120: Remove Security Manager dependencies from jdk.crypto.cryptoki module [v2]

[Sean Mullan]

On Wed, 13 Nov 2024 17:28:16 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Sean Mullan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove osName and osArch fields from Config.
>>   Remove getValue method from P11KeyAgreement.
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyAgreement.java line 77:
> 
>> 75: 
>> 76:         private static boolean getValue() {
>> 77:             return Boolean.getBoolean("jdk.crypto.KeyAgreement.legacyKDF");
> 
> I'm fine with the code as is, but is there a reason why `Boolean.getBoolean(...)` is not replacing the method call on line 74?  Is there initialization/startup concerns?

I removed the `getValue` method and changed VALUE to call `getBoolean`. It's also debatable whether it needs to be lazy initialized in a static class, but that is getting a bit beyond the scope of these changes so I left that as-is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22077#discussion_r1841109301