RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

[Weijun Wang]

On Fri, 4 Oct 2024 16:41:14 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/provider/NamedKeyPairGenerator.java line 144:
>> 
>>> 142:     /// @return public key and private key (in this order) in raw bytes
>>> 143:     /// @throws ProviderException if there is an internal error
>>> 144:     public abstract byte[][] implGenerateKeyPair(String pname, SecureRandom sr);
>> 
>> Should be protected?
>
> +1

I left them public because I have a local test that uses those method. This is definitely not a legitimate justification. I'll make them protected.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21167#discussion_r1788069074